Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScenarioOutline #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

robert-tom
Copy link

No description provided.

@bitcoder
Copy link

bitcoder commented Mar 7, 2019

@robert-tom , in this PR, on line 421 I think you need to validate the existence of a background, or else it will crash if you don't have any.

something like this seems to work out

        $scenarioSteps = 0;
        if ($event->getFeature()->getBackground() != null) {
                $scenarioSteps = count($event->getFeature()->getBackground()->getSteps()) + count($event->getOutline()->getSteps());
        } else {
                $scenarioSteps = count($event->getOutline()->getSteps());
        }

@robert-tom
Copy link
Author

You are indeed correct. I have updated the pull request.

@bitcoder bitcoder mentioned this pull request Mar 8, 2019
@bitcoder
Copy link

bitcoder commented May 3, 2019

Hi, do you think this be merged soon? It would be great, we can then make a tutorial for it in Xray's documentation.

@bitcoder
Copy link

bitcoder commented Aug 2, 2019

Hi @robert-tom, sorry for asking once again but do you think this can be merged soon? So we can have an official version supporting it? :)

@robert-tom
Copy link
Author

Hi @bitcoder, I'm not the maintainer of this package. A maintainer should merge it. ;)

@bitcoder
Copy link

bitcoder commented Aug 2, 2019

thanks @robert-tom , I think then @mytord needs to have a look at this then

@beshkenadze
Copy link
Contributor

@robert-tom thanks for your PR!
@bitcoder Unfortunately, we no longer support this project, sorry.

@bitcoder
Copy link

bitcoder commented Aug 2, 2019

so maybe we should find out a new maintainer for it? I'm not an expert in this language; not sure if @robert-tom would you be interested on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants