Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continue automatically after manual partitioning #442

Open
taukakao opened this issue Nov 22, 2024 · 3 comments · May be fixed by #444
Open

continue automatically after manual partitioning #442

taukakao opened this issue Nov 22, 2024 · 3 comments · May be fixed by #444
Labels
enhancement New feature or request

Comments

@taukakao
Copy link
Member

After manually partitioning the drive, the user has to manually press the "to the right" button to continue. This is confusing, since it's different from the Automatic partitioning behavior, which immediately asks for confirmation.
@taukakao taukakao added the enhancement New feature or request label Nov 22, 2024
@taukakao taukakao mentioned this issue Nov 22, 2024
Closed
@jardon jardon linked a pull request Nov 26, 2024 that will close this issue
Draft
@jardon
Copy link
Member

jardon commented Nov 26, 2024

whats perferred here? auto opening the confirmation dialog or just automatically moving to the next page?

@taukakao
Copy link
Member Author

@jardon
I think the confirmation dialog would be best here

@taukakao
Copy link
Member Author

If the user accidentally selected the wrong partition, or if the installer would remove the wrong volume group or something the user could still catch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create confirm modal for manual partitioning jardon/vanilla-installer
2 participants
@jardon @taukakao