feat: add manpath configuration file to the container #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axtloss
reviewed
May 20, 2024
axtloss
reviewed
May 20, 2024
Signed-off-by: K.B.Dharun Krishna <[email protected]>
axtloss
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration file for resolving manpages. (I obtained this Debian
manpath.configfile from Xenia a while ago).The file is initially included in the
includes.containerfile asman-path.config. Adding it initially would fail the CI i.e. https://github.com/Vanilla-OS/vso-image/actions/runs/8894758773/job/24423680859 (since the CI environment doesn't have access to the system thus failing theman-dbstep invoked by APT).As we discussed a while ago, I tested renaming this file in the last step of the recipe and this works perfectly.
Now, all host man pages can be accessed inside the container (as well as man pages for commands installed in a container).
Testing
I tested the change by building and pushing an image in my fork (https://github.com/kbdharun/vso-image/pkgs/container/vso) and then I built VSO modifying line 30 of
main.gofor my custom stack to work with this image locally.