[#895] Changed default behaviour for credential-process #896
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and will no longer save to ~/.aws/credentials
|
Relates to #895 |
|
Hi, will this change ensure auto-updating of .aws/credential file? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 39.72% 39.72% -0.01%
==========================================
Files 53 53
Lines 8027 8068 +41
==========================================
+ Hits 3189 3205 +16
- Misses 4411 4431 +20
- Partials 427 432 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ooof! If we merge this, the build will fail due to reduce code coverage. Mind rolling a few tests? |
mapkon
added a commit
that referenced
this pull request
May 21, 2024
Fixing saved credential issue for --credential-process introduced by #896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--credential-process now implicitly sets quiet and skip-prompt and will no longer save to ~/.aws/credentials
This prevents the need to set --quiet --skip-prompt and --credentials-file arguments for awscli to work correctly with saml2aws as credentials provider.