fix: sUM aggregation is now coalesced to 0

VeryBigThings · Apr 7, 2024 · 0d6b615 · 0d6b615
1 parent fefdb5c
commit 0d6b615
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/dialect/base.ts b/src/lib/dialect/base.ts
@@ -29,4 +29,7 @@ export class BaseDialect {
     if (value === "*") return value;
     return `"${value}"`;
   }
+  aggregateSum(sql: string) {
+    return `COALESCE(SUM(${sql}), 0)`;
+  }
 }
diff --git a/src/lib/model.ts b/src/lib/model.ts
@@ -260,7 +260,10 @@ export class Metric extends Member {
   getAggregateSql(dialect: BaseDialect, context: unknown, modelAlias?: string) {
     const { sql, bindings } = this.getSql(dialect, context, modelAlias);
     return {
-      sql: `${this.props.aggregateWith.toUpperCase()}(${sql})`,
+      sql:
+        this.props.aggregateWith === "sum"
+          ? dialect.aggregateSum(sql)
+          : `${this.props.aggregateWith.toUpperCase()}(${sql})`,
       bindings,
     };
   }