-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure API parity on all resources #327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
core
tests
labels
Mar 3, 2024
VictorAvelar
added
API parity
Changes and features missing in the client valid for the v2 API
and removed
documentation
Improvements or additions to documentation
core
tests
labels
Mar 3, 2024
VictorAvelar
added
documentation
Improvements or additions to documentation
core
tests
labels
Mar 3, 2024
VictorAvelar
changed the title
check payments resources against api reference. (#326)
Ensure API parity on all resources
Mar 3, 2024
github-actions
bot
added
gh-actions
Issues and work relates to the github actions context.
testdata
labels
Mar 3, 2024
15 tasks
VictorAvelar
added
the
v4
Changes scheduled to be released with v4 of the library.
label
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API parity
Changes and features missing in the client valid for the v2 API
core
documentation
Improvements or additions to documentation
gh-actions
Issues and work relates to the github actions context.
testdata
tests
v4
Changes scheduled to be released with v4 of the library.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an aggregate of PRs that ensure API parity is met.
Motivation and context
Multiple discrepancies have been reported over time, examples are:
Solves #316
Solves #271
How has this been tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
make test
)test data
has been added / updatedIf you are running the tests locally, please specify:
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.