Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure API parity on all resources #327

Merged
merged 27 commits into from
Mar 16, 2024

Conversation

VictorAvelar
Copy link
Owner

Description

This PR is an aggregate of PRs that ensure API parity is met.

Motivation and context

Multiple discrepancies have been reported over time, examples are:

Solves #316
Solves #271

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

  • Unit tests added / updated
  • The tests run on docker (using make test)
  • The required test data has been added / updated

If you are running the tests locally, please specify:

  • OS: macos
  • Go version 1.22

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • If my change requires a change to the documentation, I have updated it accordingly.

@github-actions github-actions bot added documentation Improvements or additions to documentation core tests labels Mar 3, 2024
@VictorAvelar VictorAvelar added API parity Changes and features missing in the client valid for the v2 API and removed documentation Improvements or additions to documentation core tests labels Mar 3, 2024
@VictorAvelar VictorAvelar self-assigned this Mar 3, 2024
@VictorAvelar VictorAvelar added documentation Improvements or additions to documentation core tests labels Mar 3, 2024
@VictorAvelar VictorAvelar changed the title check payments resources against api reference. (#326) Ensure API parity on all resources Mar 3, 2024
@github-actions github-actions bot added the config label Mar 3, 2024
@github-actions github-actions bot removed the config label Mar 3, 2024
@github-actions github-actions bot added gh-actions Issues and work relates to the github actions context. testdata labels Mar 3, 2024
@VictorAvelar VictorAvelar marked this pull request as ready for review March 16, 2024 07:52
@VictorAvelar VictorAvelar added the v4 Changes scheduled to be released with v4 of the library. label Mar 16, 2024
@VictorAvelar VictorAvelar merged commit 013a6af into master Mar 16, 2024
8 checks passed
@VictorAvelar VictorAvelar deleted the review-structs-vs-api-reference branch March 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API parity Changes and features missing in the client valid for the v2 API core documentation Improvements or additions to documentation gh-actions Issues and work relates to the github actions context. testdata tests v4 Changes scheduled to be released with v4 of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant