Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover missing test cases. #355

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Cover missing test cases. #355

merged 6 commits into from
Mar 20, 2024

Conversation

VictorAvelar
Copy link
Owner

Description

To ensure the code base is covered with tests, I went through the coverage report and fixed methods and structs which were showing low coverage.

Motivation and context

We love tests, they provide a safety net and make development easier and more enjoyable.

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

  • Unit tests added / updated
  • The tests run on docker (using make test)
  • The required test data has been added / updated

If you are running the tests locally, please specify:

  • OS: macos Sonoma
  • Go version 1.22.x

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • If my change requires a change to the documentation, I have updated it accordingly.

@VictorAvelar VictorAvelar self-assigned this Mar 20, 2024
@VictorAvelar VictorAvelar merged commit a6b7adf into master Mar 20, 2024
8 checks passed
@VictorAvelar VictorAvelar deleted the chore(tests)/coverage-check branch March 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant