Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Prometheus-compatible Histogram function, and convert the vmrange label to the le label #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/
48 changes: 48 additions & 0 deletions histogram.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"io"
"math"
"strings"
"sync"
"time"
)
Expand Down Expand Up @@ -55,6 +56,8 @@ type Histogram struct {
upper uint64

sum float64

compatible bool
}

// Reset resets the given histogram.
Expand Down Expand Up @@ -151,6 +154,9 @@ func (h *Histogram) VisitNonZeroBuckets(f func(vmrange string, count uint64)) {
func NewHistogram(name string) *Histogram {
return defaultSet.NewHistogram(name)
}
func NewCompatibleHistogram(name string) *Histogram {
return defaultSet.NewCompatibleHistogram(name)
}

// GetOrCreateHistogram returns registered histogram with the given name
// or creates new histogram if the registry doesn't contain histogram with
Expand All @@ -169,6 +175,9 @@ func NewHistogram(name string) *Histogram {
func GetOrCreateHistogram(name string) *Histogram {
return defaultSet.GetOrCreateHistogram(name)
}
func GetOrCreateCompatibleHistogram(name string) *Histogram {
return defaultSet.GetOrCreateCompatibleHistogram(name)
}

// UpdateDuration updates request duration based on the given startTime.
func (h *Histogram) UpdateDuration(startTime time.Time) {
Expand Down Expand Up @@ -201,6 +210,10 @@ var (
)

func (h *Histogram) marshalTo(prefix string, w io.Writer) {
if h.compatible {
h.marshalToPrometheus(prefix, w)
return
}
countTotal := uint64(0)
h.VisitNonZeroBuckets(func(vmrange string, count uint64) {
tag := fmt.Sprintf("vmrange=%q", vmrange)
Expand All @@ -221,6 +234,41 @@ func (h *Histogram) marshalTo(prefix string, w io.Writer) {
}
fmt.Fprintf(w, "%s_count%s %d\n", name, labels, countTotal)
}
func (h *Histogram) marshalToPrometheus(prefix string, w io.Writer) {
countTotal := uint64(0)
inf := false
h.VisitNonZeroBuckets(func(vmrange string, count uint64) {
v := strings.Split(vmrange, "...")
if len(v) != 2 {
return
}
if v[1] == "+Inf" {
inf = true
}
tag := fmt.Sprintf("le=%q", v[1])
metricName := addTag(prefix, tag)
name, labels := splitMetricName(metricName)
countTotal += count
fmt.Fprintf(w, "%s_bucket%s %d\n", name, labels, countTotal)
})
if countTotal == 0 {
return
}
if !inf {
tag := fmt.Sprintf("le=%q", "+Inf")
metricName := addTag(prefix, tag)
name, labels := splitMetricName(metricName)
fmt.Fprintf(w, "%s_bucket%s %d\n", name, labels, countTotal)
}
name, labels := splitMetricName(prefix)
sum := h.getSum()
if float64(int64(sum)) == sum {
fmt.Fprintf(w, "%s_sum%s %d\n", name, labels, int64(sum))
} else {
fmt.Fprintf(w, "%s_sum%s %g\n", name, labels, sum)
}
fmt.Fprintf(w, "%s_count%s %d\n", name, labels, countTotal)
}

func (h *Histogram) getSum() float64 {
h.mu.Lock()
Expand Down
33 changes: 33 additions & 0 deletions set.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ func (s *Set) NewHistogram(name string) *Histogram {
s.registerMetric(name, h)
return h
}
func (s *Set) NewCompatibleHistogram(name string) *Histogram {
h := &Histogram{compatible: true}
s.registerMetric(name, h)
return h
}

// GetOrCreateHistogram returns registered histogram in s with the given name
// or creates new histogram if s doesn't contain histogram with the given name.
Expand Down Expand Up @@ -112,6 +117,34 @@ func (s *Set) GetOrCreateHistogram(name string) *Histogram {
}
return h
}
func (s *Set) GetOrCreateCompatibleHistogram(name string) *Histogram {
s.mu.Lock()
nm := s.m[name]
s.mu.Unlock()
if nm == nil {
// Slow path - create and register missing histogram.
if err := validateMetric(name); err != nil {
panic(fmt.Errorf("BUG: invalid metric name %q: %s", name, err))
}
nmNew := &namedMetric{
name: name,
metric: &Histogram{compatible: true},
}
s.mu.Lock()
nm = s.m[name]
if nm == nil {
nm = nmNew
s.m[name] = nm
s.a = append(s.a, nm)
}
s.mu.Unlock()
}
h, ok := nm.metric.(*Histogram)
if !ok {
panic(fmt.Errorf("BUG: metric %q isn't a Histogram. It is %T", name, nm.metric))
}
return h
}

// NewCounter registers and returns new counter with the given name in the s.
//
Expand Down