Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform labels to string for annotations in the dashboard #253

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

dmitryk-dk
Copy link
Contributor

When the user tries to use labels in the annotations, they always transform to the [Object object] because it has Object representation.
Convert those labels to string representation.
Behavior for the Explore app stays the same for any request

Screenshot 2025-03-07 at 16 13 43

In the dashboard, we can construct annotations via the labels
Screenshot 2025-03-07 at 16 14 45

Screenshot 2025-03-07 at 16 15 03

Related issue: #188

@dmitryk-dk dmitryk-dk requested a review from Loori-R March 7, 2025 15:15
fix annotations

transform labels to string for annotations

split annotations by lines

update CHANGELOG.md

cleanup
Copy link
Contributor

@Loori-R Loori-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit 441ad57 into main Mar 11, 2025
4 checks passed
@dmitryk-dk dmitryk-dk deleted the fix-annotations-2 branch March 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants