Clarify error message about render-dependent logic #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhawksley
force-pushed
the
1926-error-messages
branch
from
56a70a4 to
9deff65
Compare
joelhawksley
force-pushed
the
1926-error-messages
branch
from
9deff65 to
b4bcbc1
Compare
BlakeWilliams
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In #1926, @coorasse pointed out that our error messages about render-dependent logic are sometimes inaccurate, as they say
during initializationdespite also being raised after a component has been initialized but before it is rendered.What approach did you choose and why?
I updated the messaging to say "before rendering" instead.