Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCST-206: Proxy XAPI subscription websocket connections #676

Merged
merged 5 commits into from
Mar 26, 2024
Merged

VCST-206: Proxy XAPI subscription websocket connections #676

merged 5 commits into from
Mar 26, 2024

Conversation

asvishnyakov
Copy link
Contributor

@asvishnyakov asvishnyakov commented Mar 6, 2024 •
edited
Loading

Description:
https://virtocommerce.atlassian.net/browse/VCST-473

  • Adds proxy for XAPI subscription WebSocket connections same way as for other XAPI HTTP requests.
  • Respect secure and insecure schemas (http -> ws, https -> wss)
  • Sets default keep alive interval to 50 seconds (XAPI has 45 and it must be XAPI < storefront < theme)

--

QA-test:

Demo-test:

Download artifact URL:

@asvishnyakov asvishnyakov marked this pull request as ready for review March 14, 2024 09:36
@asvishnyakov asvishnyakov changed the title Push notifications proxy VCST-206: Push notifications proxy Mar 14, 2024
@VirtoCommerce VirtoCommerce deleted a comment from vc-ci Mar 14, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@asvishnyakov asvishnyakov changed the title VCST-206: Push notifications proxy VCST-206: XAPI subscriptions websocket proxy Mar 14, 2024
@asvishnyakov asvishnyakov changed the title VCST-206: XAPI subscriptions websocket proxy VCST-206: Proxy XAPI subscription websocket connections Mar 14, 2024
@asvishnyakov asvishnyakov merged commit ab97932 into dev Mar 26, 2024
10 checks passed
@asvishnyakov asvishnyakov deleted the feat/VCST-473-push-notifications branch March 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegoO OlegoO OlegoO approved these changes

@ksavosteev ksavosteev ksavosteev approved these changes

Assignees
No one assigned
Labels
review task created
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvishnyakov @OlegoO @ksavosteev @vc-ci