Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --test flag with the publish & publish local sub-commands #3538

Merged

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 4, 2025

@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch from 960adf9 to 1db0434 Compare March 4, 2025 10:56
@Gedochao Gedochao changed the title Support the --test flag with the publish & publish local sub-commands Support the --test flag with the publish & publish local sub-commands Mar 4, 2025
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch from 1db0434 to 4de3b80 Compare March 4, 2025 13:11
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch 3 times, most recently from 7edaf84 to 50a9787 Compare March 12, 2025 12:32
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch 2 times, most recently from acca7b1 to 97151ee Compare March 24, 2025 14:56
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch 2 times, most recently from f8450b2 to 561b583 Compare March 25, 2025 12:25
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch 2 times, most recently from 8f1ed54 to 8f4fc4b Compare March 26, 2025 14:03
@Gedochao Gedochao requested a review from tgodzik March 26, 2025 14:55
@Gedochao Gedochao marked this pull request as ready for review March 26, 2025 14:55
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch from 8f4fc4b to 8e73d41 Compare March 26, 2025 15:07
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing, otherwise looks good

@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch from 8e73d41 to 948d119 Compare April 1, 2025 12:42
@Gedochao Gedochao force-pushed the feature/publish-with-test-scope-2 branch from 948d119 to bff50c5 Compare April 1, 2025 12:56
@Gedochao Gedochao requested a review from tgodzik April 2, 2025 07:41
@Gedochao
Copy link
Contributor Author

Gedochao commented Apr 2, 2025

Looks like tests are failing, otherwise looks good

@tgodzik should be okay now. a test needed adjusting.

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then!

@Gedochao Gedochao merged commit 020e601 into VirtusLab:main Apr 2, 2025
54 checks passed
@Gedochao Gedochao deleted the feature/publish-with-test-scope-2 branch April 2, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable including test scope inputs when publishing
2 participants