fix: [ST-2294] Hreflangs are inserted for pages that don't need trans…

…lation (#234) * fix: Hreflangs are inserted for pages that don't need translation * chore: Bump version * test: Minor refactor
WOVNio · Aug 24, 2023 · 957a552 · 957a552
1 parent 498d61e
commit 957a552
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/lib/wovnrb/services/html_converter.rb b/lib/wovnrb/services/html_converter.rb
@@ -134,7 +134,7 @@ def inject_lang_html_tag
 
     def replace_hreflangs
       strip_hreflang_tags
-      insert_hreflang_tags
+      insert_hreflang_tags if @store.settings['insert_hreflangs']
     end
 
     def strip_hreflang_tags

diff --git a/lib/wovnrb/version.rb b/lib/wovnrb/version.rb
@@ -1,3 +1,3 @@
 module Wovnrb
-  VERSION = '3.10.0'.freeze
+  VERSION = '3.10.1'.freeze
 end
diff --git a/test/lib/services/html_converter_test.rb b/test/lib/services/html_converter_test.rb
@@ -452,6 +452,26 @@ class HtmlConverterTest < WovnMiniTest
       assert(translated_html.include?(expected_html))
     end
 
+    test 'build API compatible html - with insert_hreflangs: false - hreflangs are not added' do
+      settings = default_store_settings
+      settings['insert_hreflangs'] = false
+      converter = prepare_html_converter('<html><body><a>hello</a></body></html>', settings)
+      converted_html, = converter.build_api_compatible_html
+
+      expected_html = "<html lang=\"en\"><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"><script src=\"https://j.wovn.io/1\" async=\"true\" data-wovnio=\"key=123456&amp;backend=true&amp;currentLang=en&amp;defaultLang=en&amp;urlPattern=query&amp;langCodeAliases={}&amp;langParamName=wovn&amp;version=WOVN.rb_#{VERSION}\" data-wovnio-type=\"fallback_snippet\"></script></head><body><a>hello</a></body></html>"
+      assert_equal(expected_html, converted_html)
+    end
+
+    test 'Transform HTML - with insert_hreflangs: false - hreflangs are not added' do
+      settings = default_store_settings
+      settings['insert_hreflangs'] = false
+      converter = prepare_html_converter('<html><body><a>hello</a></body></html>', settings)
+      translated_html = converter.build
+
+      expected_html = "<html lang=\"en\"><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"><script src=\"https://j.wovn.io/1\" async=\"true\" data-wovnio=\"key=123456&amp;backend=true&amp;currentLang=en&amp;defaultLang=en&amp;urlPattern=query&amp;langCodeAliases={}&amp;langParamName=wovn&amp;version=WOVN.rb_#{VERSION}\" data-wovnio-type=\"fallback_snippet\"></script></head><body><a>hello</a></body></html>"
+      assert_equal(expected_html, translated_html)
+    end
+
     private
 
     def prepare_html_converter(input_html, store_options = {})
@@ -474,15 +494,6 @@ def store_headers_factory(setting_opts = {}, url = 'http://my-site.com')
       [store, headers]
     end
 
-    test 'build API compatible html - with insert_hreflangs: false' do
-      settings = { insert_hreflangs: false }
-      converter = prepare_html_converter('<html><body><a class="test">hello</a></body></html>', settings)
-      converted_html, = converter.build_api_compatible_html
-
-      expected_html = "<html lang=\"en\"><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"><script src=\"https://j.wovn.io/1\" async=\"true\" data-wovnio=\"key=123456&amp;backend=true&amp;currentLang=en&amp;defaultLang=en&amp;urlPattern=query&amp;langCodeAliases={}&amp;langParamName=wovn&amp;version=WOVN.rb_#{VERSION}\" data-wovnio-type=\"fallback_snippet\"></script></head><body><a class=\"test\">hello</a></body></html>"
-      assert_equal(expected_html, converted_html)
-    end
-
     def default_store_settings
       {
         'project_token' => '123456',