[ST-1312] Added dynamic loading support #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstewart00
reviewed
Mar 15, 2022
bstewart00
reviewed
Mar 15, 2022
test/lib/services/time_test.rb
Outdated
Comment on lines
15
to
16
| current_time = Time.now.utc.sec | ||
| assert((TimeUtil.time_proc.call - current_time) < 2.0) |
There was a problem hiding this comment.
this test doesn't look useful. There's not any logic here, it is just a wrapper for Time.now so i don't think you need to test it.
There was a problem hiding this comment.
Yes this test might seem very redundant. But this is the only check that makes sure the time_proc is usable (we mocked it in all other tests). It's basically to make sure 1) the proc is actually callable and it is a proc and 2) it's not returning something totally unexpected (like a datetime object for example)
There was a problem hiding this comment.
Timecop would still be useful if you wanted to write this more strictly 😉
There was a problem hiding this comment.
I removed time_proc and tested with Timecop.
bstewart00
reviewed
Mar 15, 2022
bstewart00
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/goal of Pull Request (Issue #)
https://wovnio.atlassian.net/browse/ST-1312
Comments