Skip to content

Commit

Permalink
Fix crashes on older MSVC redistributable versions
Browse files Browse the repository at this point in the history
Since the switch of Windows 2022 GitHub actions runner image to version
20240603.1.1 the Visual Studio version was bumped to 17.10.34928.147.
This results in MSVC version 19.40.33811.0 being used at build time.
Combining this with e.g. the MSVC redistributable version 14.34.31938.0
results in segfaults when calling std::mutex::lock.
  • Loading branch information
WarmUpTill committed Jun 8, 2024
1 parent 9d4c8ab commit e856bda
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build-project.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,11 @@ jobs:
submodules: recursive
fetch-depth: 0

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v2
with:
vs-version: '[17.9,17.10)'

- name: Set Up Environment 🔧
id: setup
run: |
Expand Down

0 comments on commit e856bda

Please sign in to comment.