Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when changing Twitch condition type #1285

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix crash when changing Twitch condition type #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1439e54
Fix crash when changing Twitch condition type
WarmUpTill Dec 20, 2024
f359c34
Fix crash when actions were copied into a action queue
WarmUpTill Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/queue/action-queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ void ActionQueue::Add(const std::shared_ptr<MacroAction> &action)
action->Save(data);
copy->Load(data);
copy->PostLoad();
RunPostLoadSteps();
copy->ResolveVariablesToFixedValues();
_actions.emplace_back(copy);
} else {
Expand Down
3 changes: 0 additions & 3 deletions plugins/twitch/macro-condition-twitch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,8 +1427,6 @@ MacroConditionTwitchEdit::MacroConditionTwitchEdit(
QWidget::connect(_category,
SIGNAL(CategoreyChanged(const TwitchCategory &)), this,
SLOT(CategoreyChanged(const TwitchCategory &)));
QWidget::connect(this, SIGNAL(TempVarsChanged()), window(),
SIGNAL(SegmentTempVarsChanged()));
QWidget::connect(_clearBufferOnMatch, SIGNAL(stateChanged(int)), this,
SLOT(ClearBufferOnMatchChanged(int)));

Expand Down Expand Up @@ -1480,7 +1478,6 @@ void MacroConditionTwitchEdit::ConditionChanged(int idx)
_entryData->SetCondition(static_cast<MacroConditionTwitch::Condition>(
_conditions->itemData(idx).toInt()));
SetWidgetVisibility();
emit TempVarsChanged();
}

void MacroConditionTwitchEdit::TwitchTokenChanged(const QString &token)
Expand Down
1 change: 0 additions & 1 deletion plugins/twitch/macro-condition-twitch.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ private slots:

signals:
void HeaderInfoChanged(const QString &);
void TempVarsChanged();

private:
void SetWidgetVisibility();
Expand Down
Loading