Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archives SHA and bump crates versions #113

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

jprendes
Copy link
Contributor

Fix #108: Update the SHA values.
Fix #107: Update the readme and inline docs version table.

Copy link
Member

juntao commented Jul 12, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 4c4c56148cfccd4154bb3ca503c11004f9e4524e

Key Changes:

  1. Updated the version of the main crate (wasmedge-sdk) in Cargo.toml from 0.14.0 to 0.14.1.
  2. Bumped the version of the wasmedge-sys crate in both Cargo.toml and crates/wasmedge-sys/Cargo.toml from 0.19.0 to 0.19.2.
  3. Updated the WASMEDGE_RELEASE_VERSION constant in crates/wasmedge-sys/build.rs from "0.13.5" to "0.14.0".
  4. Updated the SHA values for different platforms in crates/wasmedge-sys/build.rs.

Potential Problems:

  1. The changes seem to be straightforward version updates and SHA modifications, so there might not be any major problems with the patch itself.
  2. Make sure that the updated versions are compatible with any dependencies or other crates in the project.
  3. Ensure that the SHA values in crates/wasmedge-sys/build.rs are correct and correspond to the updated archives.

Overall, the patch appears to be updating versions and corresponding SHA values, which seem fine at a high level. However, thorough testing after applying the changes is recommended to ensure the integrity of the project.

@jprendes jprendes marked this pull request as ready for review July 12, 2024 18:39
@jprendes
Copy link
Contributor Author

@L-jasmine @hydai PTAL 🙏

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @L-jasmine PTAL

@L-jasmine
Copy link
Collaborator

LGTM
Thank you so much for your pr

@L-jasmine L-jasmine merged commit dd067a3 into WasmEdge:main Jul 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts for standalone are out of sync Difficulty pairing versions of the different SDK crates
4 participants