Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated properties #360

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

valeriyvan
Copy link
Contributor

@valeriyvan valeriyvan commented Jun 19, 2023

This solves issue #359 and #354

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Jun 20, 2023

Fails
🚫

CIRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():
failed - Snapshot does not match reference.

@−
"/Users/vagrant/git/Tests/WeScanTests/Snapshots/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"
@+
"/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"

To configure output for a custom diff tool, like Kaleidoscope:

SnapshotTesting.diffTool = "ksdiff"

Actual perceptual precision 0.69906247 is less than required 0.97

🚫

VisionRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():
failed - Snapshot does not match reference.

@−
"/Users/vagrant/git/Tests/WeScanTests/Snapshots/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"
@+
"/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"

To configure output for a custom diff tool, like Kaleidoscope:

SnapshotTesting.diffTool = "ksdiff"

Newly-taken snapshot does not match reference.

Warnings
⚠️ 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
⚠️ 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
⚠️ 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
⚠️

'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)

⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
Messages
📖 WeScanTests: Executed 60 tests (2 failed, 0 retried, 0 skipped) in 13.715 seconds
📖 Slowest test: RectangleFeaturesFunnelTests/testAddAlternateImage() (4.458s)
📖 Slowest test: RectangleFeaturesFunnelTests/testAddPreviouslyDisplayedRect() (3.106s)
📖 Slowest test: RectangleFeaturesFunnelTests/testAddMinUnderThreshold() (3.031s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
WeScan 37.73% ⚠️

Generated by 🚫 Danger Swift against f986586

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@BasThomas
Copy link
Contributor

FYI @AvdLee that I suggested to remove these rather than deprecating them, given that they have been obsolete in a previous version. #359 (comment)

@valeriyvan valeriyvan changed the title Mark renamed properties as deprecated to solve build error in Xcode 15.0 beta Remove deprecated properties Jun 21, 2023
@AvdLee AvdLee merged commit d86a29b into WeTransfer:master Jun 22, 2023
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 3.0.0-beta.1 🚀

Generated by GitBuddy

mstralka added a commit to mobilelocker/WeScan that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants