MP3: add suport to id3 v2.4.x #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioperrella
requested review from
julik,
nitika080289,
linkyndy and
martijnvermaat
linkyndy
reviewed
Sep 23, 2020
julik
approved these changes
Sep 24, 2020
linkyndy
reviewed
Sep 25, 2020
fabioperrella
force-pushed
the
mp3-add-suport-to-id3v24
branch
from
a96efb6 to
ea24ae2
Compare
nitika080289
approved these changes
Sep 30, 2020
fabioperrella
force-pushed
the
mp3-add-suport-to-id3v24
branch
from
ea24ae2 to
f993e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #168
Proposal
Add support for MP3 files with id3 tag version 2.4.x
Refactoring in constant ID3V2_MINOR_TAG_VERSIONS to be easier to understand the values, given the byte notation is a bit hard to understand.
Comment
I'm not sure why we support the version 2.67 beucase it does not exist. I tried to remove it, but it broke 2 tests. Maybe @julik knows why