Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unknown v2.67 from ID3V2_TAG_VERSIONS #170

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Remove unknown v2.67 from ID3V2_TAG_VERSIONS #170

merged 1 commit into from
Sep 30, 2020

Conversation

fabioperrella
Copy link
Contributor

@fabioperrella fabioperrella commented Sep 25, 2020 •
edited
Loading

from #169 (comment)

In MP3Parser, we found out that ID3 v2.4.x is not accepted, but it accepts the version 2.67 which does not exist.

We think this version can be removed.

@fabioperrella fabioperrella mentioned this pull request Sep 25, 2020
Merged
@fabioperrella fabioperrella changed the title Remove support of unknown ID3 v2.67 Remove unknown v2.67 from ID3V2_TAG_VERSIONS Sep 25, 2020
martijnvermaat
martijnvermaat approved these changes Sep 25, 2020
View reviewed changes
Copy link

@martijnvermaat martijnvermaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me, unless @julik has other thoughts on it of course.

linkyndy
linkyndy approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@linkyndy linkyndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to write a proper description for your PRs; "from comment X" is not very helpful and it usually requires some digging in several places to find the point of the PR—which should be found in its description. You can, of course, also link to the relevant issues if it's useful 😊

@fabioperrella
Copy link
Contributor Author

It would be nice to write a proper description for your PRs; "from comment X" is not very helpful and it usually requires some digging in several places to find the point of the PR—which should be found in its description. You can, of course, also link to the relevant issues if it's useful 😊

sorry, I added a better description!

@fabioperrella fabioperrella merged commit efdc1a9 into master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julik julik julik approved these changes

@linkyndy linkyndy linkyndy approved these changes

@martijnvermaat martijnvermaat martijnvermaat approved these changes

@nitika080289 nitika080289 Awaiting requested review from nitika080289

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabioperrella @julik @linkyndy @martijnvermaat