Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jRuby seems to have broken undefined: replace behavior with String#encode #99

Closed
julik opened this issue Apr 16, 2018 · 2 comments
Closed

jRuby seems to have broken undefined: replace behavior with String#encode #99

julik opened this issue Apr 16, 2018 · 2 comments
Labels
bug good first issue

Comments

@julik
Copy link
Contributor

julik commented Apr 16, 2018

which makes it fail multiple of our tests:

https://travis-ci.org/WeTransfer/format_parser/jobs/367113788

While we do not use jRuby ourselves I think it's prudent to fix this
@julik
Copy link
Contributor Author

julik commented Apr 17, 2018

Might be related jruby/jruby#375

@kostyadubinin
Copy link
Contributor

Hey @linkyndy, I will take a look into this.

@kostyadubinin kostyadubinin mentioned this issue May 2, 2018
Merged
2 tasks
@julik julik closed this as completed in #112 May 3, 2018
julik pushed a commit that referenced this issue May 3, 2018
@kostyadubinin @julik
Make tests pass with JRuby and reinstate 2.2 compat (#112)
4b7aa2c 
Fixes #99

Rename the `String#encode` argument to `undef:` so that
jRuby becomes compatible again.

Also remove uses of the save navigation operator to restore
compatibility with MRI 2.2, since we can have it so easily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julik @kostyadubinin