Make tests pass with JRuby #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyadubinin
commented
May 2, 2018
| @@ -40,7 +40,7 @@ def directory?(zip_entry) | |||
|
|
|||
| def decode_filename(filename, likely_unicode:) | |||
| filename.force_encoding(Encoding::UTF_8) if likely_unicode | |||
| filename.encode(Encoding::UTF_8, undefined: :replace, replace: UNICODE_REPLACEMENT_CHAR) | |||
| filename.encode(Encoding::UTF_8, undef: :replace, replace: UNICODE_REPLACEMENT_CHAR) | |||
There was a problem hiding this comment.
|
Good stuff 👌 What if we remove the safe navigation operator and replace it with something more old-fashioned - will we then become compatible with 9.0? We can then reintroduce 2.2 compatibility as well? |
|
Hey Julik, I will check if the safe navigation is the only issue. |
This change is needed because JRuby 9.0 doesn't support safe navigation (&.) which is used in this gem and causes all the tests to fail. Example: https://travis-ci.org/WeTransfer/format_parser/jobs/373545169#L551 Issue in the JRuby repo: jruby/jruby#3479
|
Safe navigation turned out to be the only issue with Ruby 2.2 and JRuby 9.0. Fixed in 02d8480 Also I added the |
|
👍 cool. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99