Raise a proper error for invalid zips #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linkyndy this is the draft PR that I've mentioned about how to deal with the exception raised by some invalid ZIP files |
linkyndy
reviewed
Aug 25, 2020
fabioperrella
force-pushed
the
raise-a-proper-error-for-invalid-zips
branch
3 times, most recently
from
d04786f to
a1c17da
Compare
julik
approved these changes
Aug 25, 2020
|
Please apply Rubocop before merging 😉 |
fabioperrella
force-pushed
the
raise-a-proper-error-for-invalid-zips
branch
from
a1c17da to
c6aa74e
Compare
linkyndy
reviewed
Aug 26, 2020
linkyndy
approved these changes
Aug 26, 2020
nitika080289
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #155