MP3 parser: Ignore ID3 tags with empty values #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioperrella
requested review from
julik,
linkyndy,
martijnvermaat and
nitika080289
julik
changed the title
nitika080289
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I worked in #161 I noticed that the method
TagWrapper#to_hdoes not ignore empty strings and because of that, it can replace a id3v1tag by a empty id3v2 tag, so I added a condition to skip for empty values.Example before this change:
Example after this change:
The mp3 used as a fixture was created by me. I used the tool
id3ed(brew install id3ed) to edit the id3v1 tags