Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++11 raw string literal to embed intrinsics file. NFC #6209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Jan 6, 2024

@sbc100 sbc100 requested review from tlively and kripken January 6, 2024 17:12
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Unfortunately the windows bot here is erroring on a compiler limitation 😞

@sbc100
Copy link
Member Author

sbc100 commented Jan 8, 2024

Good idea! Unfortunately the windows bot here is erroring on a compiler limitation 😞

Looks like a limit they have removed but is present of VS 2022 and below: https://learn.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp?view=msvc-170&redirectedfrom=MSDN#size-of-string-literals

Oh well. I guess we can wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants