-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack switching proposal support #7041
Open
dhil
wants to merge
24
commits into
WebAssembly:main
Choose a base branch
from
dhil:stack-switching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 4, 2024
-
Stack switching proposal support
This patch implements text and binary encoding/decoding support for the stack switching proposal. It does so by adapting the previous typed-continunations implementation. Particular changes: * Support for new `resume` encoding. * Added support for `resume_throw` and `switch`. * Feature flag `typed-continuations` has been renamed to `stack-switching`. A small unfortunate implementation detail is that the internal name `Switch` was already taken by the `br_table` instruction, so I opted to give the `switch` instruction the internal name `StackSwitch`. A minor detail is that I have reordered the declarations/definitions of the stack switching instructions such that they appear in ascending order according to their opcode value (this is the same order that the stack-switching explainer document present them in).
Configuration menu - View commit details
-
Copy full SHA for 14af574 - Browse repository at this point
Copy the full SHA 14af574View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for edbc438 - Browse repository at this point
Copy the full SHA edbc438View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d8648 - Browse repository at this point
Copy the full SHA c0d8648View commit details -
Use inherited the 'type' member to track the continuation type in
'ContNew' and 'ContBind'
Configuration menu - View commit details
-
Copy full SHA for 98f6314 - Browse repository at this point
Copy the full SHA 98f6314View commit details -
Configuration menu - View commit details
-
Copy full SHA for c407262 - Browse repository at this point
Copy the full SHA c407262View commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15fcbc6 - Browse repository at this point
Copy the full SHA 15fcbc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1866bc - Browse repository at this point
Copy the full SHA d1866bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b06c76 - Browse repository at this point
Copy the full SHA 2b06c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b339f9 - Browse repository at this point
Copy the full SHA 3b339f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0886451 - Browse repository at this point
Copy the full SHA 0886451View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d76f260 - Browse repository at this point
Copy the full SHA d76f260View commit details -
Revert "Don't (re)compute sentTypes for resume and resume_throw."
This reverts commit d1866bc.
Configuration menu - View commit details
-
Copy full SHA for 1c2ed8a - Browse repository at this point
Copy the full SHA 1c2ed8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8bf255 - Browse repository at this point
Copy the full SHA c8bf255View commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e16e47 - Browse repository at this point
Copy the full SHA 9e16e47View commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 157552a - Browse repository at this point
Copy the full SHA 157552aView commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 480843d - Browse repository at this point
Copy the full SHA 480843dView commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8d345a - Browse repository at this point
Copy the full SHA c8d345aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0110dd5 - Browse repository at this point
Copy the full SHA 0110dd5View commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f418774 - Browse repository at this point
Copy the full SHA f418774View commit details
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3bedcb5 - Browse repository at this point
Copy the full SHA 3bedcb5View commit details
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1d65ce - Browse repository at this point
Copy the full SHA b1d65ceView commit details
Commits on Nov 28, 2024
-
[WIP] Eliminate type immediate members.
This commit is a partial solution to removing the type immediate members from `cont.new,cont.bind,resume,resume_throw,switch`. However, when I fully remove the type immediates then I observe a crash in `child-ir.h` on `visitContBind,visitResume,visitResumeThrow,visitStackSwitch`. It seems that `curr->cont->type` is sometimes not a continuation type...
Configuration menu - View commit details
-
Copy full SHA for c549cd7 - Browse repository at this point
Copy the full SHA c549cd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a20680 - Browse repository at this point
Copy the full SHA 6a20680View commit details
Commits on Dec 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2a3fabe - Browse repository at this point
Copy the full SHA 2a3fabeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.