allow specifying the external memory #7125
Open
+134
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 27, 2024
| for (auto& export : module->exports) { | ||
| if (export->kind == ExternalKind::Memory && | ||
| export->name == asyncifyMemoryValue) { | ||
| asyncifyMemory = export->value; |
There was a problem hiding this comment.
Suggested change
| asyncifyMemory = export->value; | |
| asyncifyMemory = export->value; | |
| break; |
kripken
reviewed
Dec 2, 2024
| @@ -0,0 +1,116 @@ | |||
| ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited. | |||
| ;; NOTE: This test was ported using port_passes_tests_to_lit.py and could be cleaned up. | |||
There was a problem hiding this comment.
Suggested change
| ;; NOTE: This test was ported using port_passes_tests_to_lit.py and could be cleaned up. |
| ;; NOTE: This test was ported using port_passes_tests_to_lit.py and could be cleaned up. | ||
|
|
||
| ;; RUN: foreach %s %t wasm-opt --enable-multimemory --enable-mutable-globals --asyncify --pass-arg=asyncify-memory@memory -S -o - | filecheck %s | ||
|
|
There was a problem hiding this comment.
Suggested change
| ;; This test checks that the asyncify-memory argument can pick which memory to use in asyncify. |
Comment on lines
+7
to
+8
| (memory (export "memory") 1 1) | ||
| (memory (export "unused") 1 1) |
There was a problem hiding this comment.
Suggested change
| (memory (export "memory") 1 1) | |
| (memory (export "unused") 1 1) | |
| (memory $mem (export "memory") 1 1) | |
| (memory $ignore (export "unused") 1 1) |
Indentation, and give them names. The names should make the test output easier to read. (Can update the output using ./scripts/update_lit_checks.py PATH-TO-TEST)
There was a problem hiding this comment.
(I intentionally did not use the export names, so that the test verifies we use the export names to pick the memory.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying the memory used in Asyncify in case of multiple memories via an export.