Makefile refactoring; NFC #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are several changes here, but they're split into commits which can be reviewed independently. |
sbc100
reviewed
Mar 18, 2020
They theoretically protect what the Makefile considers to be implementation details from being overridden on the command-line, but in practice this isn't super important, and they add a lot of clutter.
sbc100
approved these changes
Mar 18, 2020
sbc100
reviewed
Mar 18, 2020
| install: finish | ||
| mkdir -p "$(INSTALL_DIR)" | ||
| cp -r "$(SYSROOT)/lib" "$(SYSROOT)/share" "$(SYSROOT)/include" "$(INSTALL_DIR)" | ||
|
|
||
| .PHONY: default startup_files libc finish check install include_dirs | ||
| .PHONY: default startup_files libc finish install include_dirs |
There was a problem hiding this comment.
Don't you feel like there is value is having a separate check rule? I guess we always build from clean anyway, so its not like you could build and then check later with the current setup?
There was a problem hiding this comment.
The check code is very quick -- it's just a diff of a few files -- so we can just always do the check as part of the regular build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several Makefile refactorings which were previously folded into #150, now pulled out to address #150 (comment). NFC.