-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use compnerd/cmake's build of wasi-libc #94
Conversation
int_util.c:57 includes stdlib.h, which isnt a new thing. was there just a race that it used to always win?
Makefile
Outdated
--install \ | ||
-DCMAKE_SYSTEM_NAME=Generic \ | ||
-DCMAKE_AR=$(ROOT_DIR)/bin/llvm-ar \ | ||
-DCMAKE_NM=$(ROOT_DIR)/bin/llvm-nm \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pre-existing, but we can remove the "llvm-" from these commands, as we install a plain "nm" and "ar" now.
thanks dan for pointing out we dont need the prefix
cmake wont be able to execute the wasm program output by wasi-sdk's clang
i thought that was what --install would do. oh well
Drop the explicit |
Subsequent build steps (compiler-rt) are calling the clang built prior to build, and requires some headers provided by wasi-libc. Clang's system include path is searching at $(PREFIX)/share/wasi-sysroot. So, we need to install wasi-libc to that location for the rest of the build to work, and for it to end up in the packages created by this repo. |
@pchickey sorry if what I was saying was unclear. What I meant is that something like this should work:
That will generate a proper sysroot in |
@compnerd thanks, that fix got us through compiler-rt, but now libcxx is failing. Any ideas? |
Seems that |
I never got back to this and it isn't a priority, so closing for now. If anyone else wants to take this work on, feel free to re-open. |
Using this PR to get the CI system to try building with wasi-libc's new CMamke based build system, by @compnerd
WebAssembly/wasi-libc#154 (comment)