Skip to content

Minor spec changes based on TAG feedback #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor spec changes based on TAG feedback #150

wants to merge 1 commit into from

Conversation

evanbliu
Copy link
Collaborator

@evanbliu evanbliu commented Apr 18, 2025 •
edited by pr-preview bot
Loading

This CL contains the following changes based on TAG feedback (w3ctag/design-reviews#1038 (comment)):

  1. Remove the 'cloud-only' option for SpeechRecognitionMode.
  2. Add a statement that speech recognition should not be personalized when performing speech recognition on a MediaStreamTrack.
  3. Clarify that user agents MAY show a permission prompt when downloading language packs.

Preview | Diff

@evanbliu evanbliu requested a review from padenot April 18, 2025 21:14
jyasskin
jyasskin reviewed Apr 21, 2025
View reviewed changes
index.bs
@@ -409,7 +410,7 @@ See <a href="https://lists.w3.org/Archives/Public/public-speech-api/2012Sep/0072
1. Let <var>promise</var> be <a>a new promise</a>.
1. Initiate the download of the on-device speech recognition language for <var>lang</var>.
<p class=note>
Note: The user agent can prompt the user for explicit permission to download the on-device speech recognition language pack.
Note: The user agent MAY prompt the user for explicit permission to download the on-device speech recognition language pack.
Copy link
Contributor

@jyasskin jyasskin Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not supposed to use MAY inside a non-normative paragraph like a note, and in fact you should turn on Complain About: accidental-2119 in the bikeshed metadata to flag when you do it by accident (as suggested in #147). Instead, you'll need to specify the actions the UA must take if the user denies permission, similar to "If the user explicitly or implicitly signals that they do not want to start the download" in https://pr-preview.s3.amazonaws.com/webmachinelearning/writing-assistance-apis/pull/47.html#step-download-user-interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it enabled in another PR but forgot to merge, this is now done (with another lint).

padenot
padenot requested changes Apr 23, 2025
View reviewed changes
index.bs
@@ -409,7 +410,7 @@ See <a href="https://lists.w3.org/Archives/Public/public-speech-api/2012Sep/0072
1. Let <var>promise</var> be <a>a new promise</a>.
1. Initiate the download of the on-device speech recognition language for <var>lang</var>.
<p class=note>
Note: The user agent can prompt the user for explicit permission to download the on-device speech recognition language pack.
Note: The user agent MAY prompt the user for explicit permission to download the on-device speech recognition language pack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it enabled in another PR but forgot to merge, this is now done (with another lint).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyasskin jyasskin jyasskin left review comments

@padenot padenot padenot requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evanbliu @jyasskin @padenot @evliu-google