-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[RISCV] Fix instruction requires the following: 'D'/'F'/'M' #36461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISCV] Fix instruction requires the following: 'D'/'F'/'M' #36461
Conversation
EWS run on previous version of this PR (hash e7ca076) |
This issue is caused by a bug in llvm, and I think this PR is currently harmless.
|
@@ -566,6 +566,7 @@ JSValue CLoop::execute(OpcodeID entryOpcodeID, void* executableAddress, VM* vm, | |||
ALIGNMENT \ | |||
ALT_ENTRY(label) \ | |||
".globl " SYMBOL_STRING(label) "\n" \ | |||
".attribute arch, \"rv64gc\"" "\n" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to enable it only for RISCV64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
e7ca076
to
97eb199
Compare
EWS run on previous version of this PR (hash 97eb199) |
97eb199
to
6ae82b4
Compare
EWS run on previous version of this PR (hash 6ae82b4) |
Seems like EWS are failing. |
6ae82b4
to
57d1228
Compare
EWS run on current version of this PR (hash 57d1228) |
done |
https://bugs.webkit.org/show_bug.cgi?id=282900 Reviewed by Yusuke Suzuki. This is a llvm bug, passing `-march=riscv64gc -cpu=lp64d` from clang will lost after it got llvm side. So we have to set arch here. More related infomations are here: - rust-lang/rust#80608 - llvm/llvm-project#61991 - llvm/llvm-project#97685 * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.cpp: * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: Canonical link: https://commits.webkit.org/286815@main
57d1228
to
fff4bd8
Compare
Committed 286815@main (fff4bd8): https://commits.webkit.org/286815@main Reviewed commits have been landed. Closing PR #36461 and removing active labels. |
Backported in the 2.46 branch as commit 53c63d7 |
fff4bd8
57d1228