Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3 Cleanup types within ServiceDictionary #9

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ncipollo
Copy link
Contributor

@ncipollo ncipollo commented Dec 13, 2023

Fixes #3

Copy link

@mibattaglia mibattaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nonblocking question then :shipit:

Comment on lines +2 to +5
on:
push:
branches: ["main", "release*"]
pull_request:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity what does this do? run a CI testing workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - this will run tests whenever you push to main, release(anything), or open a PR.

@ncipollo ncipollo merged commit 4e75f9b into main Dec 14, 2023
1 check passed
@ncipollo ncipollo deleted the ncipollo/3/type-cleanup branch December 14, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type cleanup
2 participants