Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gif()
function in paparazzi creates multiple images per test. The resulting files each have an appended index, for example:etc...
When validating against existing snapshots, Paparazzi currently looks for the file name without the appended index, since this is what non-gif snapshots need to validate against. For example:
To solve this problem, this PR creates a GifSnapshotHandler which will ensure that the correct index is appended to each file name before validating against the golden images. We can easily hook this up into gif tests by overriding the snapshotHandler in our test rule