Fe 1045 eslint v9 upgrade #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e5ad8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
avo
reviewed
Jul 11, 2024
avo
reviewed
Jul 11, 2024
avo
reviewed
Jul 11, 2024
Co-authored-by: Anna Vo <[email protected]>
avo
reviewed
Jul 11, 2024
avo
reviewed
Jul 11, 2024
avo
reviewed
Jul 11, 2024
avo
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to eslint v9 which had some major changes to how the config is handled. Apps will need to update to the latest for all eslint related deps outlined in the readme. They will also need to convert their .eslintrc and .eslintignore over to eslint.config.mjs. Some of the plugins (https://github.com/typescript-eslint/typescript-eslint) we use do not yet support v9 directly so we are using a compatability layer see
FlatCompatwithin eslint.config.mjs. Once the plugins have updated we'll be able to replace the FlatCompat code with direct plugin references in the export array.https://eslint.org/docs/latest/use/migrate-to-9.0.0
https://eslint.org/docs/latest/use/configure/migration-guide
https://acquia.atlassian.net/browse/FE-1045