Skip to content

Commit

Permalink
feat(style): upgrade ionicons (#5)
Browse files Browse the repository at this point in the history
This removes the dated version of Ionicons and upgrades to latest, which 
now injects itself using a script (not sure how we feel about this - as 
when I disabled JS, the icon simply no longer render).

Anyway, I know there was discussion about moving off of Ionicons and 
leveraging the same icon set in our product suite, but this was easy and 
could tide us over for a while.
  • Loading branch information
dbeg authored Jul 30, 2020
1 parent b6e5e5a commit 6615ad9
Show file tree
Hide file tree
Showing 12 changed files with 6 additions and 4,491 deletions.
8 changes: 4 additions & 4 deletions _includes/footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
</nav >
<nav>
<ul class="site-social-links inline">
<li><a target="_blank" title="RSS Feed" href="/feed.xml" class="ion-social-rss"></a></li>
<li><a target="_blank" title="RSS Feed" href="/feed.xml"><ion-icon name="logo-rss"></ion-icon></a></li>
{% if site.guardian.social_links.email_subscription_url %}
<li><a target="_blank" title="Email Subscription" href="{{ site.guardian.social_links.email_subscription_url }}" class="ion-email-unread"></a></li>
<li><a target="_blank" title="Email Subscription" href="{{ site.guardian.social_links.email_subscription_url }}"><ion-icon name="mail"></ion-icon></a></li>
{% endif %}
<li><a target="_blank" title="GitHub" href="https://github.com/{{ site.guardian.social_links.github_org }}" class="ion-social-github"></a></li>
<li><a target="_blank" title="Twitter" href="https://twitter.com/{{ site.guardian.social_links.twitter }}" class="ion-social-twitter"></a></li>
<li><a target="_blank" title="GitHub" href="https://github.com/{{ site.guardian.social_links.github_org }}"><ion-icon name="logo-github"></ion-icon></a></li>
<li><a target="_blank" title="Twitter" href="https://twitter.com/{{ site.guardian.social_links.twitter }}"><ion-icon name="logo-twitter"></ion-icon></a></li>
</ul>
</nav>
<p>© Copyright {{ site.time | date: '%Y' }}, <a title="Widen Homepage" target="_blank" href="http://widen.com">Widen Enterprises, Inc.</a></p>
Expand Down
1 change: 1 addition & 0 deletions _includes/scripts.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<script src="https://unpkg.com/[email protected]/dist/ionicons.js"></script>
1 change: 1 addition & 0 deletions _layouts/default.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
</div>

{% include analytics.html %}
{% include scripts.html %}

</body>

Expand Down
27 changes: 0 additions & 27 deletions _sass/ionicons/_ionicons-font.scss

This file was deleted.

Loading

0 comments on commit 6615ad9

Please sign in to comment.