[added] Make modal portal have the dialog role (reactjs#223)

closes reactjs#212
Widen · Sep 21, 2016 · 2e806c7 · 2e806c7
1 parent abe88a8
commit 2e806c7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/components/ModalPortal.js b/lib/components/ModalPortal.js
@@ -201,7 +201,8 @@ var ModalPortal = module.exports = React.createClass({
           tabIndex: "-1",
           onKeyDown: this.handleKeyDown,
           onMouseDown: this.handleContentMouseDown,
-          onMouseUp: this.handleContentMouseUp
+          onMouseUp: this.handleContentMouseUp,
+          role: "dialog"
         },
           this.props.children
         )

diff --git a/specs/Modal.spec.js b/specs/Modal.spec.js
@@ -58,6 +58,13 @@ describe('Modal', function () {
     unmountModal();
   });
 
+  it('renders the modal content with a dialog aria role ', function () {
+    var child = 'I am a child of Modal, and he has sent me here...';
+    var component = renderModal({isOpen: true}, child);
+    equal(component.portal.refs.content.getAttribute('role'), 'dialog');
+    unmountModal();
+  });
+
   it('has default props', function() {
     var node = document.createElement('div');
     Modal.setAppElement(document.createElement('div'));