forked from reactjs/react-modal
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fixed] Make the modal portal render into body again (reactjs#176)
In c13fed9 behavior was changed so that the modal portal ended up rendering into the app element. In the default case where the appElement receives aria-hidden when the modal is open, this meant that the modal itself was also contained inside the aria-hidden element. This limits the ability for screenreaders to read the modal contents. Server-side rendering should not be affected by this change because componentDidMount is only fired on the client-side thus having a reference to document.body there should be acceptable. Upgrade Path: - Make sure that you are setting an app element (rather than using the default document.body) so that modal contents are not being aria-hidden
- Loading branch information
1 parent
e9aff7a
commit 9089a2d
Showing
2 changed files
with
4 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters