Skip to content

Commit

Permalink
Moves classnames to dependencies
Browse files Browse the repository at this point in the history
This makes it a bit more compatible with the way peerDependencies will work in `npm@3` later down the line.
It also makes it so that consumers of the lib can have another version of classnames at the app level while
not requiring this particular lib to require a version bump.  Plus, this lib sorta depends on it and should
it need to be locked down to a particular version, this lib should manage that rather than expect it to
happen at the app level.
  • Loading branch information
claydiffrient committed Jun 7, 2015
1 parent 48eed00 commit fbb07d4
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@
"uglify-js": "2.4.15",
"webpack-dev-server": "1.6.5"
},
"peerDependencies": {
"react": ">=0.12.0",
"dependencies": {
"classnames": "^1.2.0"
},
"peerDependencies": {
"react": ">=0.12.0"
},
"tags": [
"react",
"modal",
Expand All @@ -57,4 +59,4 @@
"browserify-shim": {
"react": "global:React"
}
}
}

0 comments on commit fbb07d4

Please sign in to comment.