Skip to content

Commit

Permalink
Add support for next_page_token_path for Simple Header Paginator (#46)
Browse files Browse the repository at this point in the history
* Update README.md

* Update streams.py

* Update README.md

* Update streams.py

change according to review
  • Loading branch information
OBakalash authored Apr 3, 2024
1 parent 7230cc4 commit 083346f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -630,4 +630,4 @@ meltano elt tap-rest-api-msdk target-jsonl
### SDK Dev Guide

See the [dev guide](https://sdk.meltano.com/en/latest/dev_guide.html) for more instructions on how to use the SDK to
develop your own taps and targets.
develop your own taps and targets.
3 changes: 3 additions & 0 deletions tap_rest_api_msdk/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ def get_new_paginator(self):
elif (
self.pagination_request_style == "simple_header_paginator"
): # Example Gitlab.com
if self.next_page_token_jsonpath:
return JSONPathPaginator(self.next_page_token_jsonpath)

return SimpleHeaderPaginator("X-Next-Page")
elif self.pagination_request_style == "header_link_paginator":
return HeaderLinkPaginator()
Expand Down

0 comments on commit 083346f

Please sign in to comment.