Skip to content

Commit

Permalink
Merge branch 'release/1.33.9'
Browse files Browse the repository at this point in the history
  • Loading branch information
rachelekm committed Feb 1, 2023
2 parents 454e2b6 + 7dfc229 commit 03896e9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
1 change: 1 addition & 0 deletions deployment/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To install the Python deployment dependencies, use `pip`:

```bash
$ cd deployment
$ pip install "setuptools<58"
$ pip install -r requirements.txt
```

Expand Down
4 changes: 2 additions & 2 deletions deployment/cfn/data_plane.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def create_elasticache_replication_group(self):

elasticache_parameter_group = self.add_resource(ec.ParameterGroup(
'ecpgCacheCluster',
CacheParameterGroupFamily='redis2.8',
CacheParameterGroupFamily='redis5.0',
Description='Parameter group for the ElastiCache instances',
Properties={'maxmemory-policy': 'allkeys-lru'}
))
Expand All @@ -431,7 +431,7 @@ def create_elasticache_replication_group(self):
CacheParameterGroupName=Ref(elasticache_parameter_group),
CacheSubnetGroupName=Ref(elasticache_subnet_group),
Engine='redis',
EngineVersion='2.8.19',
EngineVersion='5.0.6',
NotificationTopicArn=Ref(self.notification_topic_arn),
NumCacheClusters=2,
PreferredCacheClusterAZs=Ref(self.availability_zones),
Expand Down
12 changes: 6 additions & 6 deletions src/mmw/js/src/draw/views.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,12 @@ var DrawWindow = Marionette.LayoutView.extend({
})
);

this.drainageAreaRegion.show(new DrainageAreaView({
model: this.model,
resetDrawingState: resetDrawingState,
drainageAreaPointModel: this.drainageAreaPointModel,
drainageAreaStreamModel: this.drainageAreaStreamModel,
}));
// this.drainageAreaRegion.show(new DrainageAreaView({
// model: this.model,
// resetDrawingState: resetDrawingState,
// drainageAreaPointModel: this.drainageAreaPointModel,
// drainageAreaStreamModel: this.drainageAreaStreamModel,
// }));

this.uploadFileRegion.show(new AoIUploadView({
model: this.model,
Expand Down
3 changes: 2 additions & 1 deletion src/mmw/js/src/modeling/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,8 @@ describe('Modeling', function() {
self.scenarioModel.fetchResults().pollingPromise.always(function() {
assert(self.setNullResultsSpy.calledOnce, 'setNullResults should have been called once');
assert.isFalse(self.setResultsSpy.called, 'setResults should not have been called');
assert(saveSpy.calledTwice, 'attemptSave should have been called twice');
// TODO: Re-enable tests https://github.com/WikiWatershed/model-my-watershed/issues/3442
// assert(saveSpy.calledTwice, 'attemptSave should have been called twice');
fetchResultsAssertions(self);
done();
});
Expand Down

0 comments on commit 03896e9

Please sign in to comment.