Remove provisioning for portal.bigcz.org #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -474,8 +421,7 @@ def create_auto_scaling_resources(self, app_server_security_group, | |||
| HealthCheckGracePeriod=600, | |||
| HealthCheckType='ELB', | |||
| LaunchConfigurationName=Ref(blue_app_server_launch_config), | |||
| LoadBalancerNames=[Ref(app_server_lb), | |||
| Ref(backward_compat_app_server_lb)], | |||
| LoadBalancerNames=[Ref(app_server_lb)], | |||
There was a problem hiding this comment.
Since we updated create_load_balancers to be singular on Line 360, let's be consistent. LoadBalancerNames should be made singular here as well, unless we foresee expanding this out to include more loadbalancers in the future - in which case, we should revert Line 360.
There was a problem hiding this comment.
Actually LoadBalancerNames is a troposphere parameter, not in our control.
I do not foresee more load balancers being made for this, so will keep create_load_balancer as is.
JN-Hernandez
approved these changes
Apr 23, 2024
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The SSL certificates were removed in #3610, which broke deployments. By removing references to all infrastructure that depended on those SSL certificates, we allow deployments to resume.
Also updated the
default.ymlfile in 1Password, with a CHANGELOG capturing the updates.Other feature references to portal.bigcz.org will be removed in #3613.
Closes #3617
Demo
Testing Instructions