Add interactivity to the Advice section #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lists every new style advice (nadvice.el) of a callable in the Advice section instead of simply saying that it is advised. Further, a button is provided for each advice to remove it. Another button is provided to remove all advices from the callable. This also removes old style advices. Mentions of all advices in the docstring (the "This function has :around advice:" line) are removed, regardless of whether they come before the docstring or after (Emacs 28 change), or whether they come from advice.el or nadvice.el. (helpful--advices): New function that returns new style (nadvice.el) advices of a given symbol (helpful--skip-advice): Remove docstring mentions of new style advices (helpful-update): Only show Advice section if we're describing a callable; revamp Advice section
|
Been looking forward to functionality of interactive advice toggling for quite a while. To sweet not to merge! |
This was referenced Aug 29, 2022
|
Great! It would be better if it supports hooks as well 😁 |
|
@kisaragi-hiu |
CeleritasCelery
added a commit
to CeleritasCelery/helpful
that referenced
this pull request
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lists every new style advice (nadvice.el) of a callable in the Advice section instead of simply saying that it is advised. Further, a button is provided for each advice to remove it.
Another button is provided to remove all advices from the callable. This also removes old style advices.
Mentions of all advices in the docstring (the "This function has :around advice:" line) are removed, regardless of whether they come before the docstring or after (Emacs 28 change), or whether they come from advice.el or nadvice.el.
helpful--advices: New function that returns new style (nadvice.el) advices of a given symbolhelpful--skip-advice: Remove docstring mentions of new style adviceshelpful-update: Only show Advice section if we're describing a callable; revamp Advice sectionThis is similar in spirit to #265. The differences are:
advice--symbol-functionand other nadvice.el utilities instead of the docstringad-Advice-..., I fall back to the "this {function,macro} is advised" text as removing the old style advice using new style advice utilities seems wrong.