fix: mentions causing bot to mis-identity user, markdown codes not wo…

…rking correctly
WiseGPT · Dec 29, 2022 · 4aa9872 · 4aa9872
1 parent 789dfda
commit 4aa9872
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/application/slack-adapter/slack-event-handler.ts b/src/application/slack-adapter/slack-event-handler.ts
@@ -5,6 +5,8 @@ import { SlackMessageEventWithEnvelope } from "../../domain/slack-adapter/slack-
 import { SlackConversationDynamodbRepository } from "../../infrastructure/dynamodb/slack-conversation-dynamodb.repository";
 
 export class SlackEventHandler {
+  private static readonly STRIP_INITIAL_MENTION_REGEX = /^(\s*<@[^>]+>\s*)/;
+
   private static tryGetMessageStartingMention(
     envelope: SlackMessageEventWithEnvelope
   ): { userId: string } | undefined {
@@ -35,6 +37,10 @@ export class SlackEventHandler {
     return authorization?.is_bot ? authorization?.user_id : undefined;
   }
 
+  private static stripInitialMention(text: string): string {
+    return text.replace(this.STRIP_INITIAL_MENTION_REGEX, "");
+  }
+
   constructor(
     private readonly repository = new SlackConversationDynamodbRepository(),
     private readonly commandBus: CommandBus = globalCommandBus
@@ -91,7 +97,7 @@ export class SlackEventHandler {
         message: {
           id: event.ts,
           author: { userId: event.user },
-          text: event.text,
+          text: SlackEventHandler.stripInitialMention(event.text),
         },
       });
     }
@@ -107,7 +113,7 @@ export class SlackEventHandler {
       initialMessage: {
         id: event.ts,
         author: { userId: event.user },
-        text: event.text,
+        text: SlackEventHandler.stripInitialMention(event.text),
       },
       metadata: {
         threadId: ts,

diff --git a/src/domain/persona/slack-software-eng/slack-software-eng.persona.ts b/src/domain/persona/slack-software-eng/slack-software-eng.persona.ts
@@ -5,7 +5,7 @@ export const slackSoftwareEngPersona: Persona = {
   name: "slack-software-eng",
   basePrompt: `Instructions for ${config.bot.name}:
 You're a regular Slack user.
-When you want to provide code examples, you wrap them around triple backticks.
+When providing code examples, use triple backticks and do not suffix the markdown shortcut for the language. 
 You always like providing lengthy responses and explaining things.
 You are helpful and descriptive.
 You make well-informed decisions and cite your sources if you can.