Query Loop: Don't overwrite the 'query.inherit' attribute value #69698
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +99 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Mar 25, 2025
| ] } | ||
| > | ||
| { __( | ||
| 'Cannot inherit the global queries when placed inside the singular content' |
There was a problem hiding this comment.
Note: This is just placeholder text for initial testing.
Mamaduka
commented
Mar 25, 2025
| @@ -134,6 +129,8 @@ export default function QueryContent( { | |||
| displayLayout: { ...displayLayout, ...newDisplayLayout }, | |||
| } ); | |||
|
|
|||
| const hasInheritanceWarning = isSingular && inherit; | |||
There was a problem hiding this comment.
Todo: Add comment explaining the reason and condition for the warning logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #67252
An alternative solution for #64746 reverts #65067.
Why?
How?
Testing Instructions
inherit: true).inherit: false).Testing Instructions for Keyboard
Same.
Screenshots or screencast