-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable U2F Interface unless already configured. #571
Open
dd32
wants to merge
6
commits into
WordPress:master
Choose a base branch
from
dd32:disable/fido-u2f-unless-configured
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3388d45
Disable U2F / FIDO interface unless the user has keys enabled.
dd32 dbb400d
Add a filter to allow turning it back on.
dd32 6fc25a7
Remove U2F references from readme
dd32 36171c0
Document the filter.
dd32 415d305
Document where the filter is documented.
dd32 684c2d3
Merge branch 'master' into disable/fido-u2f-unless-configured
dd32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,6 +61,15 @@ public static function enqueue_assets( $hook ) { | |
|
||
$security_keys = Two_Factor_FIDO_U2F::get_security_keys( $user_id ); | ||
|
||
// Disabled interface if there's no keys. | ||
if ( | ||
! $security_keys && | ||
/** This filter is documented in class-two-factor-core.php */ | ||
apply_filters( 'two_factor_u2f_disabled', true ) | ||
) { | ||
return; | ||
} | ||
|
||
// @todo Ensure that scripts don't fail because of missing u2fL10n. | ||
try { | ||
$data = Two_Factor_FIDO_U2F::$u2f->getRegisterData( $security_keys ); | ||
|
@@ -164,6 +173,15 @@ protected static function asset_version() { | |
* @param WP_User $user WP_User object of the logged-in user. | ||
*/ | ||
public static function show_user_profile( $user ) { | ||
// Don't display if the user cannot configure it. | ||
if ( | ||
! Two_Factor_FIDO_U2F::get_instance()->is_available_for_user( $user ) && | ||
/** This filter is documented in class-two-factor-core.php */ | ||
apply_filters( 'two_factor_u2f_disabled', true ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here -- should we pass the |
||
) { | ||
return; | ||
} | ||
|
||
wp_nonce_field( "user_security_keys-{$user->ID}", '_nonce_user_security_keys' ); | ||
$new_key = false; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pass the user object to the filter to match the original?