Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #640

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Release 0.10.0 #640

merged 5 commits into from
Dec 2, 2024

Conversation

kasparsd
Copy link
Collaborator

@kasparsd kasparsd commented Sep 18, 2024

Push out all the minor improvements before a major release.

What's Changed

New Contributors

Full Changelog: 0.9.1...master

@kasparsd
Copy link
Collaborator Author

@dd32 I see that in #625 we bumped both PHP and WP core requirements which would require a major release in my opinion.

Is there an practical need to bump those? Considering the important use-case for this plugin, I wonder if we can delay the requirement bumps until when actually needed them?

Or did any of the session work actually need the WP bump?

@jeffpaul What are your thoughts on this?

@kasparsd kasparsd requested a review from jeffpaul September 18, 2024 15:55
@dd32
Copy link
Member

dd32 commented Sep 19, 2024

@dd32 I see that in #625 we bumped both PHP and WP core requirements which would require a major release in my opinion.

Personally, I disagree on that. Underlying requirements like this are background noise to 90% of people and does not signifiy anything major.
But happy for it to go out as 0.10.0 if you see fit?

Is there an practical need to bump those? Considering the important use-case for this plugin, I wonder if we can delay the requirement bumps until when actually needed them?

Considering what sites actually update plugins, this isn't really a concern to me, especially given the changes are not improving the sites security, and is more of a bugfix.

I did some digging for stat data for you, for 0.9.x of the plugin:

  • the PHP bump will affect 0.15% of users (1% If we include users of < 0.9)
  • the WP bump will affect 2.6% of 0.9.1 users (A singular site somewhere is using 0.9.0 + WP 6.2 according to the data, and nothing lower)
    The overlap is that 100% of the old PHP users are running an older WP.

Edit: I guess the requirement bumps can be held back too I guess, but keep in mind that it's untested, and those WordPress sites are already considered unsupported.

@kasparsd kasparsd changed the title [DRAFT] Release 0.9.2 [DRAFT] Release 0.10.0 Sep 19, 2024
@jeffpaul
Copy link
Member

@kasparsd there's still a decent amount of items in the 0.10.0 milestone, how much of that do you want to get pulled into this draft release and how can I help move those items along?

@jeffpaul
Copy link
Member

@kasparsd any preference for the items in the 0.10.0 milestone that I can help get closer to done/merged to include in the release versus shipping what's currently merged in and punting the rest to the 0.11.0 milestone?

@kasparsd kasparsd marked this pull request as ready for review December 2, 2024 09:49
@kasparsd kasparsd changed the title [DRAFT] Release 0.10.0 Release 0.10.0 Dec 2, 2024
@kasparsd
Copy link
Collaborator Author

kasparsd commented Dec 2, 2024

@jeffpaul Personally I find the amount of items in the 0.10.0 milestone to be pretty overwhelming, and would suggest we do a release with whatever has been merged as it includes some major improvements.

I realize that this would require shifting the milestone items around -- is that a concern for you?

@kasparsd
Copy link
Collaborator Author

kasparsd commented Dec 2, 2024

Considering that this release (and the included improvements) has been waiting around for a while, I'll go ahead and push it out. Monday gives us plenty of time to address any feedback.

@kasparsd kasparsd merged commit 990c967 into master Dec 2, 2024
48 checks passed
@jeffpaul jeffpaul modified the milestones: 0.11.0, 0.10.0 Dec 2, 2024
@jeffpaul
Copy link
Member

jeffpaul commented Dec 2, 2024

I realize that this would require shifting the milestone items around -- is that a concern for you?

All updated here in GitHub, should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants