Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sticky comments for README Diff #127

Merged
merged 1 commit into from
Dec 5, 2024
+4 −2
Merged

Use sticky comments for README Diff #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/helm-charts-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
run: |
make generate
- name: Check that the files are the exact same
uses: LouisBrunner/diff-action@v2.0.0
uses: LouisBrunner/diff-action@v2.1.0
with:
old: charts/${{ matrix.chart }}/README.current.md
new: charts/${{ matrix.chart }}/README.md
Expand All @@ -63,6 +63,8 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
notify_check: true
notify_issue: true
sticky_comment: true
title: ${{ matrix.chart }}
validate-values-schema:
runs-on: ubuntu-latest
name: Validate values schema json
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ Opinionated helm chats for my personal projects, and OSS Projects that either do
## Opinionated decisions shared by all charts

* All have pod anti-affinity to be not be on the same node
* All deployments have a pod disruption budget that only allows one unavailble pod when there are more then one replicas
* All deployments have a pod disruption budget that only allows one unavailable pod when there are more then one replicas
Loading