Skip to content

Untrusted Validator Squelching - Extends squelching to limit untrusted validator message propagation #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Tapanito
Copy link
Collaborator

@Tapanito Tapanito commented Apr 11, 2025

This feature improves network efficiency by limiting message propagation from untrusted validators.

Squelching currently reduces the volume of duplicate messages from validators but does not address the volume of unique messages from untrusted validators, who may not contribute meaningfully to network progress.

This change introduces a bounded number of slots for untrusted validators, selected based on unique message frequency and quantity. Once selected, their duplicate messages are subject to standard squelching logic, thereby reducing overall message overhead without impacting trusted validator performance.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch from 901d5ce to bd11905 Compare May 2, 2025 09:03
@Tapanito Tapanito changed the title DRAFT: enhanced squelching algorithm to reduce untrusted validator traffic Extend squelching to limit untrusted validator message propagation May 2, 2025
@Tapanito Tapanito marked this pull request as ready for review May 2, 2025 09:22
@Tapanito Tapanito requested review from vlntb, bthomee and gregtatcam May 2, 2025 09:22
@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch from ed26e8a to 57bc3ea Compare May 2, 2025 09:50
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 46.81818% with 117 lines in your changes missing coverage. Please review.

Project coverage is 78.6%. Comparing base (9e1fe9a) to head (2a9c386).

Files with missing lines Patch % Lines
src/xrpld/overlay/Slot.h 60.1% 67 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.cpp 0.0% 34 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 15 Missing ⚠️
src/xrpld/overlay/Squelch.h 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5399     +/-   ##
=========================================
- Coverage     78.7%   78.6%   -0.1%     
=========================================
  Files          816     816             
  Lines        70542   70667    +125     
  Branches      8284    8335     +51     
=========================================
+ Hits         55494   55551     +57     
- Misses       15048   15116     +68     
Files with missing lines Coverage Δ
src/xrpld/core/Config.h 85.7% <ø> (ø)
src/xrpld/core/detail/Config.cpp 75.9% <100.0%> (+0.1%) ⬆️
src/xrpld/overlay/detail/OverlayImpl.h 38.4% <ø> (ø)
src/xrpld/overlay/Squelch.h 69.6% <0.0%> (ø)
src/xrpld/overlay/detail/PeerImp.cpp 3.7% <0.0%> (-<0.1%) ⬇️
src/xrpld/overlay/detail/OverlayImpl.cpp 34.0% <0.0%> (-0.7%) ⬇️
src/xrpld/overlay/Slot.h 74.9% <60.1%> (-9.9%) ⬇️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tapanito Tapanito mentioned this pull request May 2, 2025
13 tasks
@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch 2 times, most recently from 1d36ebc to c689fbd Compare May 7, 2025 13:16
@Tapanito Tapanito changed the title Extend squelching to limit untrusted validator message propagation Untrusted Validator Squelching - Extends squelching to limit untrusted validator message propagation May 8, 2025
@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch 3 times, most recently from 3dd5f5c to 894706f Compare May 13, 2025 08:40
@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch 2 times, most recently from b3b8d25 to 5ec71e7 Compare May 21, 2025 14:16
@bthomee bthomee added this to the 2.6.0 (Q3 2025) milestone May 27, 2025
Tapanito added 9 commits May 28, 2025 15:57
This feature improves network efficiency by limiting message propagation from untrusted validators.

Squelching currently reduces the volume of duplicate messages from validators but does not address the volume of unique messages from untrusted validators, who may not contribute meaningfully to network progress.

This change introduces a bounded number of slots for untrusted validators, selected based on message frequency. Once selected, their duplicate messages are subject to standard squelching logic, thereby reducing overall message overhead without impacting trusted validator performance.
@Tapanito Tapanito force-pushed the tapanito/feature/enhanced-squelching branch from 5ec71e7 to a038b70 Compare May 28, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants