Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Rename HandBoundsMode to HandBoundsLOD for better understanding #677

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Rename HandBoundsMode to HandBoundsLOD for better understanding #677

merged 3 commits into from
Nov 11, 2020

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Nov 10, 2020 •
edited
Loading

XRTK - Mixed Reality Toolkit Pull Request

Overview

As per #645 I renamed the HandBoundsMode enum so people understand what it's about. Just a minor tweak.

Changes

  • Renamed HandBoundsMode.Hand|.Fingers to HandBoundsLOD.Low|.High

Submodule Changes

@FejZa FejZa mentioned this pull request Nov 10, 2020
Merged
@FejZa FejZa mentioned this pull request Nov 10, 2020
Open
22 tasks
@FejZa FejZa added the Ready for review PR finished primary development, open for review label Nov 10, 2020
StephenHodgson
StephenHodgson previously approved these changes Nov 10, 2020
View reviewed changes
@StephenHodgson
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@StephenHodgson
Copy link
Contributor

Getting script compile errors

Assets\XRTK.Examples\Demos\HandControllerDemo\Scripts\HandPhysicsDemoStation.cs(33,83): error CS0103: The name 'HandBoundsMode' does not exist in the current context
Assets\XRTK.Examples\Demos\HandControllerDemo\Scripts\HandPhysicsDemoStation.cs(34,85): error CS0103: The name 'HandBoundsMode' does not exist in the current context
Assets\XRTK.Examples\Demos\HandControllerDemo\Scripts\HandPhysicsDemoStation.cs(69,43): error CS0103: The name 'HandBoundsMode' does not exist in the current context
Assets\XRTK.Examples\Demos\HandControllerDemo\Scripts\HandPhysicsDemoStation.cs(80,43): error CS0103: The name 'HandBoundsMode' does not exist in the current context

@FejZa
Copy link
Contributor Author

FejZa commented Nov 11, 2020

Aaah forgot about the examples. Thanks, will fix.

@FejZa FejZa mentioned this pull request Nov 11, 2020
Merged
@FejZa
Copy link
Contributor Author

FejZa commented Nov 11, 2020

@StephenHodgson updated the examples repo as well and created PR.

@StephenHodgson StephenHodgson merged commit 98df981 into development Nov 11, 2020
@StephenHodgson StephenHodgson deleted the dev/hand-bounds-mode-rename branch November 11, 2020 16:19
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
@FejZa
Rename HandBoundsMode to HandBoundsLOD for better understanding (#677)
430441b 
* Rename HandBoundsMode to HandBoundsLOD

* Update SDK checkout

* Update submodules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHodgson StephenHodgson StephenHodgson approved these changes

@SimonDarksideJ SimonDarksideJ Awaiting requested review from SimonDarksideJ

Assignees
No one assigned
Labels
Breaking Change Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FejZa @StephenHodgson