PETOSS-575 Fix Linting Issues in Dotnet SDK: Fix Warnings while runni…

…ng Dotnet Build (#567)

* initial commit

* adds formating script

* updated the package to 8.0 from 6.0

* testing commit

* reverted changes for suppression

---------

Co-authored-by: vigneshk-tw <[email protected]>

Xero.NetStandard.OAuth2.Test/Api/PayrollAuApiTests.cs

@@ -37,7 +37,6 @@ public class PayrollAuApiTests : IAsyncLifetime
         private const string accessToken = "XeroNetStandardTestAccessToken";
         private const string xeroTenantId = "XeroNetStandardTestTenantId";
         private PayrollAuApi instance;
-        private readonly ITestOutputHelper output;
 
         public PayrollAuApiTests()
         {

Xero.NetStandard.OAuth2.Test/Model/Bankfeeds/FeedConnectionTests.cs

@@ -53,9 +53,9 @@ public void Dispose()
         [Theory]
         [InlineData("BANK", FeedConnection.AccountTypeEnum.BANK)]
         [InlineData("CREDITCARD", FeedConnection.AccountTypeEnum.CREDITCARD)]
-        public void AccountType_ValidInputs_Deserialises(string input, FeedConnection.AccountTypeEnum expected)
+        public async Task AccountType_ValidInputs_Deserialises(string input, FeedConnection.AccountTypeEnum expected)
         {
-            JsonDoc.Assert<FeedConnection, FeedConnection.AccountTypeEnum>(
+            await JsonDoc.Assert<FeedConnection, FeedConnection.AccountTypeEnum>(
                 input: new JsonDoc.String(nameof(FeedConnection.AccountType), input),
                 toProperty: (x) => x.AccountType,
                 shouldBe: expected
@@ -68,9 +68,9 @@ public void AccountType_ValidInputs_Deserialises(string input, FeedConnection.Ac
         [Theory]
         [InlineData("PENDING", FeedConnection.StatusEnum.PENDING)]
         [InlineData("REJECTED", FeedConnection.StatusEnum.REJECTED)]
-        public void Status_ValidInputs_Deserialises(string input, FeedConnection.StatusEnum expected)
+        public async Task Status_ValidInputs_Deserialises(string input, FeedConnection.StatusEnum expected)
         {
-            JsonDoc.Assert<FeedConnection, FeedConnection.StatusEnum>(
+            await JsonDoc.Assert<FeedConnection, FeedConnection.StatusEnum>(
                 input: new JsonDoc.String(nameof(FeedConnection.Status), input),
                 toProperty: (x) => x.Status,
                 shouldBe: expected

Xero.NetStandard.OAuth2.Test/Model/Bankfeeds/PaginationTests.cs

@@ -20,6 +20,7 @@
 using Xero.NetStandard.OAuth2.Client;
 using System.Reflection;
 using Newtonsoft.Json;
+using System.Threading.Tasks;
 
 namespace Xero.NetStandard.OAuth2.Test.Model.Bankfeeds
 {
@@ -47,9 +48,9 @@ public void Dispose()
         /// Test the property 'Page' deserialises from a valid int
         /// </summary>
         [Fact]
-        public void Page_ValidInteger_Deserialises()
+        public async Task Page_ValidInteger_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Number(nameof(Pagination.Page), "20"),
                 toProperty: (t) => t.Page,
                 shouldBe: 20
@@ -59,9 +60,9 @@ public void Page_ValidInteger_Deserialises()
         /// Test the property 'Page' deserialises from null
         /// </summary>
         [Fact]
-        public void Page_Null_Deserialises()
+        public async Task Page_Null_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Null(nameof(Pagination.Page)),
                 toProperty: (t) => t.Page,
                 shouldBe: null
@@ -71,9 +72,9 @@ public void Page_Null_Deserialises()
         /// Test the property 'PageSize' deserialises from a valid int
         /// </summary>
         [Fact]
-        public void PageSize_ValidInteger_Deserialises()
+        public async Task PageSize_ValidInteger_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Number(nameof(Pagination.PageSize), "20"),
                 toProperty: (t) => t.PageSize,
                 shouldBe: 20
@@ -83,9 +84,9 @@ public void PageSize_ValidInteger_Deserialises()
         /// Test the property 'PageSize' deserialises from null
         /// </summary>
         [Fact]
-        public void PageSize_Null_Deserialises()
+        public async Task PageSize_Null_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Null(nameof(Pagination.PageSize)),
                 toProperty: (t) => t.PageSize,
                 shouldBe: null
@@ -95,9 +96,9 @@ public void PageSize_Null_Deserialises()
         /// Test the property 'PageCount' deserialises from a valid int
         /// </summary>
         [Fact]
-        public void PageCount_ValidInteger_Deserialises()
+        public async Task PageCount_ValidInteger_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Number(nameof(Pagination.PageCount), "20"),
                 toProperty: (t) => t.PageCount,
                 shouldBe: 20
@@ -107,9 +108,9 @@ public void PageCount_ValidInteger_Deserialises()
         /// Test the property 'PageCount' deserialises from null
         /// </summary>
         [Fact]
-        public void PageCount_Null_Deserialises()
+        public async Task PageCount_Null_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Null(nameof(Pagination.PageCount)),
                 toProperty: (t) => t.PageCount,
                 shouldBe: null
@@ -119,9 +120,9 @@ public void PageCount_Null_Deserialises()
         /// Test the property 'ItemCount' deserialises from a valid int
         /// </summary>
         [Fact]
-        public void ItemCount_ValidInteger_Deserialises()
+        public async Task ItemCount_ValidInteger_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Number(nameof(Pagination.ItemCount), "20"),
                 toProperty: (t) => t.ItemCount,
                 shouldBe: 20
@@ -131,9 +132,9 @@ public void ItemCount_ValidInteger_Deserialises()
         /// Test the property 'ItemCount' deserialises from null
         /// </summary>
         [Fact]
-        public void ItemCount_Null_Deserialises()
+        public async Task ItemCount_Null_Deserialises()
         {
-            JsonDoc.Assert<Pagination, int?>(
+            await JsonDoc.Assert<Pagination, int?>(
                 input: new JsonDoc.Null(nameof(Pagination.ItemCount)),
                 toProperty: (t) => t.ItemCount,
                 shouldBe: null

Xero.NetStandard.OAuth2.Test/Model/Bankfeeds/StatementLineTests.cs

@@ -20,6 +20,7 @@
 using Xero.NetStandard.OAuth2.Client;
 using System.Reflection;
 using Newtonsoft.Json;
+using System.Threading.Tasks;
 
 namespace Xero.NetStandard.OAuth2.Test.Model.Bankfeeds
 {
@@ -49,9 +50,9 @@ public void Dispose()
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void Amount_ValidInputs_Deserialises(string input)
+        public async Task Amount_ValidInputs_Deserialises(string input)
         {
-            JsonDoc.Assert<StatementLine, decimal?>(
+            await JsonDoc.Assert<StatementLine, decimal?>(
                 input: new JsonDoc.Number(nameof(StatementLine.Amount), input),
                 toProperty: (x) => x.Amount,
                 shouldBe: 20m

Xero.NetStandard.OAuth2.Test/Model/PayrollAu/DeductionTypeTests.cs

@@ -20,6 +20,7 @@
 using Xero.NetStandard.OAuth2.Client;
 using System.Reflection;
 using Newtonsoft.Json;
+using System.Threading.Tasks;
 
 namespace Xero.NetStandard.OAuth2.Test.Model.PayrollAu
 {
@@ -50,9 +51,9 @@ public void Dispose()
         [InlineData("NONE", DeductionType.DeductionCategoryEnum.NONE)]
         [InlineData("UNIONFEES", DeductionType.DeductionCategoryEnum.UNIONFEES)]
         [InlineData("WORKPLACEGIVING", DeductionType.DeductionCategoryEnum.WORKPLACEGIVING)]
-        public void DeductionCategory_ValidInputs_Deserialises(string input, DeductionType.DeductionCategoryEnum expected)
+        public async Task DeductionCategory_ValidInputs_Deserialises(string input, DeductionType.DeductionCategoryEnum expected)
         {
-            JsonDoc.Assert<DeductionType, DeductionType.DeductionCategoryEnum>(
+            await JsonDoc.Assert<DeductionType, DeductionType.DeductionCategoryEnum>(
                 input: new JsonDoc.String(nameof(DeductionType.DeductionCategory), input),
                 toProperty: (x) => x.DeductionCategory,
                 shouldBe: expected

Xero.NetStandard.OAuth2.Test/Model/PayrollAu/EarningsLineTests.cs

@@ -20,6 +20,7 @@
 using Xero.NetStandard.OAuth2.Client;
 using System.Reflection;
 using Newtonsoft.Json;
+using System.Threading.Tasks;
 
 namespace Xero.NetStandard.OAuth2.Test.Model.PayrollAu
 {
@@ -49,9 +50,9 @@ public void Dispose()
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void AnnualSalaryTest(string input)
+        public async Task AnnualSalaryTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.AnnualSalary), input),
                 toProperty: x => x.AnnualSalary,
                 shouldBe: 20m
@@ -63,9 +64,9 @@ public void AnnualSalaryTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void NumberOfUnitsPerWeekTest(string input)
+        public async Task NumberOfUnitsPerWeekTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.NumberOfUnitsPerWeek), input),
                 toProperty: x => x.NumberOfUnitsPerWeek,
                 shouldBe: 20m
@@ -77,9 +78,9 @@ public void NumberOfUnitsPerWeekTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void RatePerUnitTest(string input)
+        public async Task RatePerUnitTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.RatePerUnit), input),
                 toProperty: x => x.RatePerUnit,
                 shouldBe: 20m
@@ -91,9 +92,9 @@ public void RatePerUnitTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void NormalNumberOfUnitsTest(string input)
+        public async Task NormalNumberOfUnitsTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.NormalNumberOfUnits), input),
                 toProperty: x => x.NormalNumberOfUnits,
                 shouldBe: 20m
@@ -105,9 +106,9 @@ public void NormalNumberOfUnitsTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void AmountTest(string input)
+        public async Task AmountTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.Amount), input),
                 toProperty: x => x.Amount,
                 shouldBe: 20m
@@ -119,9 +120,9 @@ public void AmountTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void NumberOfUnitsTest(string input)
+        public async Task NumberOfUnitsTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.NumberOfUnits), input),
                 toProperty: x => x.NumberOfUnits,
                 shouldBe: 20m
@@ -133,9 +134,9 @@ public void NumberOfUnitsTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void FixedAmountTest(string input)
+        public async Task FixedAmountTest(string input)
         {
-            JsonDoc.Assert<EarningsLine, decimal?>(
+            await JsonDoc.Assert<EarningsLine, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsLine.FixedAmount), input),
                 toProperty: x => x.FixedAmount,
                 shouldBe: 20m
@@ -148,9 +149,9 @@ public void FixedAmountTest(string input)
         [InlineData("USEEARNINGSRATE", EarningsRateCalculationType.USEEARNINGSRATE)]
         [InlineData("ANNUALSALARY", EarningsRateCalculationType.ANNUALSALARY)]
         [InlineData("ENTEREARNINGSRATE", EarningsRateCalculationType.ENTEREARNINGSRATE)]
-        public void CalculationType_ValidInputs_Deserialises(string input, EarningsRateCalculationType expected)
+        public async Task CalculationType_ValidInputs_Deserialises(string input, EarningsRateCalculationType expected)
         {
-            JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
+            await JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
                 input: new JsonDoc.String(nameof(EarningsLine.CalculationType), input),
                 toProperty: x => x.CalculationType,
                 shouldBe: expected
@@ -160,9 +161,9 @@ public void CalculationType_ValidInputs_Deserialises(string input, EarningsRateC
         /// Test the property 'CalculationType' deserialises from null
         /// </summary>
         [Fact]
-        public void CalculationType_NullInput_DeserialisesTo0()
+        public async Task CalculationType_NullInput_DeserialisesTo0()
         {
-            JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
+            await JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
                 input: new JsonDoc.Null(nameof(EarningsLine.CalculationType)),
                 toProperty: x => x.CalculationType,
                 shouldBe: 0
@@ -172,9 +173,9 @@ public void CalculationType_NullInput_DeserialisesTo0()
         /// Test the property 'CalculationType' deserialises when not present
         /// </summary>
         [Fact]
-        public void CalculationType_NotPresent_DeserialisesTo0()
+        public async Task CalculationType_NotPresent_DeserialisesTo0()
         {
-            JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
+            await JsonDoc.Assert<EarningsLine, EarningsRateCalculationType>(
                 input: new JsonDoc.NotPresent(nameof(EarningsLine.CalculationType)),
                 toProperty: x => x.CalculationType,
                 shouldBe: 0

Xero.NetStandard.OAuth2.Test/Model/PayrollAu/EarningsRateTests.cs

@@ -20,6 +20,7 @@
 using Xero.NetStandard.OAuth2.Client;
 using System.Reflection;
 using Newtonsoft.Json;
+using System.Threading.Tasks;
 
 namespace Xero.NetStandard.OAuth2.Test.Model.PayrollAu
 {
@@ -57,9 +58,9 @@ public void Dispose()
         [InlineData("LUMPSUME", EarningsType.LUMPSUME)]
         [InlineData("ORDINARYTIMEEARNINGS", EarningsType.ORDINARYTIMEEARNINGS)]
         [InlineData("OVERTIMEEARNINGS", EarningsType.OVERTIMEEARNINGS)]
-        public void EarningsTypeTest(string input, EarningsType expected)
+        public async Task EarningsTypeTest(string input, EarningsType expected)
         {
-            JsonDoc.Assert<EarningsRate, EarningsType>(
+            await JsonDoc.Assert<EarningsRate, EarningsType>(
                 input: new JsonDoc.String(nameof(EarningsRate.EarningsType), input),
                 toProperty: e => e.EarningsType,
                 shouldBe: expected
@@ -72,9 +73,9 @@ public void EarningsTypeTest(string input, EarningsType expected)
         [InlineData("FIXEDAMOUNT", RateType.FIXEDAMOUNT)]
         [InlineData("MULTIPLE", RateType.MULTIPLE)]
         [InlineData("RATEPERUNIT", RateType.RATEPERUNIT)]
-        public void RateTypeTest(string input, RateType expected)
+        public async Task RateTypeTest(string input, RateType expected)
         {
-            JsonDoc.Assert<EarningsRate, RateType>(
+            await JsonDoc.Assert<EarningsRate, RateType>(
                 input: new JsonDoc.String(nameof(EarningsRate.RateType), input),
                 toProperty: e => e.RateType,
                 shouldBe: expected
@@ -86,9 +87,9 @@ public void RateTypeTest(string input, RateType expected)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void MultiplierTest(string input)
+        public async Task MultiplierTest(string input)
         {
-            JsonDoc.Assert<EarningsRate, decimal?>(
+            await JsonDoc.Assert<EarningsRate, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsRate.Multiplier), input),
                 toProperty: x => x.Multiplier,
                 shouldBe: 20
@@ -100,9 +101,9 @@ public void MultiplierTest(string input)
         [Theory]
         [InlineData("20.00")]
         [InlineData("20")]
-        public void AmountTest(string input)
+        public async Task AmountTest(string input)
         {
-            JsonDoc.Assert<EarningsRate, decimal?>(
+            await JsonDoc.Assert<EarningsRate, decimal?>(
                 input: new JsonDoc.Number(nameof(EarningsRate.Amount), input),
                 toProperty: x => x.Amount,
                 shouldBe: 20
@@ -114,9 +115,9 @@ public void AmountTest(string input)
         [Theory]
         [InlineData("O", EmploymentTerminationPaymentType.O)]
         [InlineData("R", EmploymentTerminationPaymentType.R)]
-        public void EmploymentTerminationPaymentTypeTest(string input, EmploymentTerminationPaymentType expected)
+        public async Task EmploymentTerminationPaymentTypeTest(string input, EmploymentTerminationPaymentType expected)
         {
-            JsonDoc.Assert<EarningsRate, EmploymentTerminationPaymentType>(
+            await JsonDoc.Assert<EarningsRate, EmploymentTerminationPaymentType>(
                 input: new JsonDoc.String(nameof(EarningsRate.EmploymentTerminationPaymentType), input),
                 toProperty: x => x.EmploymentTerminationPaymentType,
                 shouldBe: expected
@@ -132,9 +133,9 @@ public void EmploymentTerminationPaymentTypeTest(string input, EmploymentTermina
         [InlineData("OTHER", AllowanceType.OTHER)]
         [InlineData("TRANSPORT", AllowanceType.TRANSPORT)]
         [InlineData("TRAVEL", AllowanceType.TRAVEL)]
-        public void AllowanceTypeTest(string input, AllowanceType expected)
+        public async Task AllowanceTypeTest(string input, AllowanceType expected)
         {
-            JsonDoc.Assert<EarningsRate, AllowanceType>(
+            await JsonDoc.Assert<EarningsRate, AllowanceType>(
                 input: new JsonDoc.String(nameof(EarningsRate.AllowanceType), input),
                 toProperty: x => x.AllowanceType,
                 shouldBe: expected

Xero.NetStandard.OAuth2.Test/Model/PayrollAu/EmployeeTests.cs

@@ -103,9 +103,9 @@ public async Task Gender_NotPresentInInput_DeserialisesTo0()
         [Theory]
         [InlineData("ACTIVE", EmployeeStatus.ACTIVE)]
         [InlineData("TERMINATED", EmployeeStatus.TERMINATED)]
-        public void StatusTest(string input, EmployeeStatus expected)
+        public async Task StatusTest(string input, EmployeeStatus expected)
         {
-            JsonDoc.Assert<Employee, EmployeeStatus>(
+            await JsonDoc.Assert<Employee, EmployeeStatus>(
                 input: new JsonDoc.String(nameof(Employee.Status), input),
                 toProperty: x => x.Status,
                 shouldBe: expected